Merged
Conversation
Collaborator
ravjotbrar
commented
Nov 20, 2025
ravjotbrar
commented
- by default hot-keys starts the monitor, runs it for one cycle, then stops the monitor
- add a param to hot-keys that indicates that the user will be the one stopping the monitor; so the hot-keys endpoint will start the monitor;
- return data after one duration and keep the monitor running, and just always respond with the data. The user will have to call monitor stop themselves.
- add a field to the response of hotkeys — monitorStatus
arseny-kostenko
previously approved these changes
Nov 20, 2025
Signed-off-by: Ravjot Brar <Ravjot.Brar@VAN-FM2FQ6NHXT.local>
Signed-off-by: Ravjot Brar <Ravjot.Brar@VAN-FM2FQ6NHXT.local>
Signed-off-by: Ravjot Brar <83892020+ravjotbrar@users.noreply.github.com>
arseny-kostenko
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.